-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installation of java11 version of nexus #424
base: main
Are you sure you want to change the base?
Conversation
Add optional "nexus_suffix" variable. Can be set to "java11" to fetch the java11 version instead of the default java8 version starting with 3.76.0
IMHO #417 has a nicer way of handling java8 and java11 versions. |
Thanks for the pointer. I think my way has some upsides as #417 will break downloads for older version (<3.67) and will also likely need further changes in the future. But as a user either version is fine for me :-) |
Any news on this change? |
From the newly released version 3.71.0 on Nexus will only support Java17 and the H2 DB. The corresponding download archive of Nexus has the format https://download.sonatype.com/nexus/3/nexus-3.71.0-06-mac.tgz. This PR can't handle this new situation and needs to be supplemented to work also with the newest Nexus version. |
I would expect setting |
Hi @bgp-sz |
@bgp-sz that wouldnt work in your code. It would result in the following string: The question is do we want to support this role for macOS targets (and maybe Windows) as well? |
You are right, i didn't read it properly. As you mentioned, this role never supported mac, and I think it's a bit out of scope of this PR. You can always not set |
Add optional "nexus_suffix" variable.
Can be set to "java11" to fetch the java11 version instead of the default java8 version starting with 3.76.0