Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Generate stats in HTML #157

Open
aaditkamat opened this issue Jan 2, 2021 · 3 comments · May be fixed by #158
Open

FEAT: Generate stats in HTML #157

aaditkamat opened this issue Jan 2, 2021 · 3 comments · May be fixed by #158
Assignees
Labels
Brainstorming Some New Feature to be added with prior proper discussion help wanted Extra attention is needed

Comments

@aaditkamat
Copy link
Contributor

aaditkamat commented Jan 2, 2021

Is your feature request related to a problem? Please describe.
My GitHub README was cluttered because of the different features I had included. So I rewrote it using HTML to include each section under the respective <details> tag. This will ensure that the sections can be opened and closed on demand. However, since GitHub Flavoured Markdown does not render properly within HTML, the current template does not allow me to organize the content into sections.

Describe the solution you'd like
I'd like to provide an additional flag INPUT_RENDER_HTML that can be set so that the README stats are generated with HTML markup instead of Markdown. This way a user like me can add a specific HTML section for these stats.

@aaditkamat aaditkamat added the Brainstorming Some New Feature to be added with prior proper discussion label Jan 2, 2021
@aaditkamat aaditkamat changed the title FEAT FEAT: Generate stats in HTML Jan 2, 2021
@aaditkamat aaditkamat linked a pull request Jan 2, 2021 that will close this issue
@pseusys pseusys added the help wanted Extra attention is needed label Mar 1, 2023
@pseusys
Copy link
Collaborator

pseusys commented Mar 1, 2023

I think this requuires further consideration: maybe we should add an option for output generation in html file completely?
Will this be required for any other purpose apart from the one you described?

In general I think that since this action is about MD we should keep MD syntax whenever it's possible.

@mfsbo
Copy link

mfsbo commented Mar 22, 2023

Agree that this action is intended for file used by github to create your profile. HTML format for global might be needed in some cases but the approach seems too generic to me.

Format to enhance that profile should be within the limits of gihub flavoured syntax used in readme. For example if stats can be represented with a diagram then using Mermaid to draw a diagram and update it based on stats should be first choice.

The FLAG input render html is too generic and I would rather introduce specific feature based format flags so you can specify if you want to have your projects section in html or md format you can set FORMAT_PROJECTS flag to certain format value.

These flags are not just true and false then we can have values like

FORMAT_PROJECTS: "MD | HTML | Mermaid"

Then if we have finished testing FORMAT_* flags for all sections we can introduce FORMAT = "MD | HTML" Flag. Which then simply set a group of format variables to html instead of md.

My inspiration is based on Locale flag which allows people to use stats in their own language.

@pseusys
Copy link
Collaborator

pseusys commented Mar 22, 2023

@mfsbo For now if you are familiar with these diagram drawing features, you are welcomed to suggest a markdown-based solution for diagrams generation instead of current matplotlib-based.
I think this could've simplify the project by a lot and also resolve many potential bugs and issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Brainstorming Some New Feature to be added with prior proper discussion help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants