-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lists should be exposed to Kotlin as List
, not MutableList
#334
Comments
I've had a quick Google, but no obvious annotations came up to tell the kotlin compiler that the Java list should be If it means we need to port our codegen to Kotlin, this is likely not worthwhile |
Where are you seeing mutable? I looked in the generated Note.java, and it's a plain list: /**
* <code>repeated string fields = 7;</code>
* @return A list containing the fields.
*/
@java.lang.Override
public java.util.List<java.lang.String> getFieldsList() {
return fields_;
} |
Sorry, ignore me - I assumed that List was always an immutable variant in Java, but apparently that's not the case. |
And this is not our codegen by the way - it's the output of protoc. |
Backend Codegen is problematic: it exposes a
java.util.List
, but this is actually acom.google.protobuf.Internal.ProtobufList
.ProtobufList
throws on mutationhttps://protobuf.dev/reference/java/api-docs/com/google/protobuf/Internal.ProtobufList
Reported in: ankidroid/Anki-Android#14948
The text was updated successfully, but these errors were encountered: