Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--animate-delay has no effect (and I think that I’ve figured out why) #1793

Open
handcoding opened this issue Jun 14, 2024 · 0 comments · May be fixed by #1838
Open

--animate-delay has no effect (and I think that I’ve figured out why) #1793

handcoding opened this issue Jun 14, 2024 · 0 comments · May be fixed by #1838
Labels

Comments

@handcoding
Copy link

handcoding commented Jun 14, 2024

Describe The Bug

The docs mention that users can add --animate-delay to their CSS to delay when a given animation starts. But this CSS variable seems to have no effect.

Safari - Animate css  A cross-browser library of CSS animations  - 2024-06 at 11-12-58

Steps To Reproduce

  1. Run this minimized test case, which includes --animate-delay: 5s; on an element:
    https://codepen.io/handcoding/pen/dyEZxoJ

Expected Behavior

The expected behavior is that this element would animate after a delay of 5 seconds.

Desktop

  • OS: macOS Sonoma
  • Browser: Safari and Chrome and Firefox (that I’ve tested so far)
  • version: animate.css 4.1.1

Additional Context

I believe that I’ve figured out why this is happening.

In animate.css's base .animate__animated class, the library programmatically connects the animation-duration CSS property to its variable through animation-duration: var(--animate-duration); (which is good!).

.... but then the library’s .animate__animated class doesn’t also connect the animation-delay CSS property to its corresponding --animate-delay variable.

So the upshot is that if you set, say, --animate-delay: 5s; on an element, there ends up being no delay at all.

@charset "UTF-8";/*!
 * animate.css - https://animate.style/
 * Version - 4.1.1
 * Licensed under the MIT license - http://opensource.org/licenses/MIT
 *
 * Copyright (c) 2020 Animate.css
 */
:root {
  --animate-duration: 1s;
  --animate-delay: 1s;
  --animate-repeat: 1;
}
.animate__animated {
  -webkit-animation-duration: 1s;
  animation-duration: 1s;
  -webkit-animation-duration: var(--animate-duration);
  animation-duration: var(--animate-duration);
  -webkit-animation-fill-mode: both;
  animation-fill-mode: both;
}

[…]

PS I believe that the --animate-repeat CSS variable is also affected by this since that doesn’t appear to be programmatically connected to its corresponding CSS property within .animate__animated either.

@handcoding handcoding added the bug label Jun 14, 2024
@handcoding handcoding changed the title --animate-delay has no effect (and I think that I’ve figured out why) --animate-delay has no effect (and I think that I’ve figured out why) Jun 14, 2024
abhijeetsingh-0 pushed a commit to abhijeetsingh-0/animate.css that referenced this issue Oct 28, 2024
Yohn added a commit to Yohn/animate.css that referenced this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant