Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming mistake in animate.css flippers (X and Y axis) #1572

Open
artisticLogicMK opened this issue Jul 22, 2022 · 4 comments
Open

Naming mistake in animate.css flippers (X and Y axis) #1572

artisticLogicMK opened this issue Jul 22, 2022 · 4 comments
Labels

Comments

@artisticLogicMK
Copy link

Describe The Bug

I noticed in animate.css that the flipper animations are named incorrectly. 'X axis' is mistaken for 'Y axis.'

*flipInX and flipOutX should flip horizontally on X axis but they flip vertically on Y axis.
*flipInY and flipOutY should flip vertically on the Y axis but they flip horizontally on the X axis.

Steps To Reproduce

No response

Expected Behavior

No response

Screenshots

No response

Desktop

No response

Smartphone

No response

Additional Context

No response

@artisticLogicMK artisticLogicMK changed the title Name mistake in animate.css flippers (X and Y axis) Naming mistake in animate.css flippers (X and Y axis) Jul 22, 2022
@eltonmesquita
Copy link
Collaborator

You are right! Thanks for catching this one, it should be fixed on v5 as this is a breaking change

@warengonzaga
Copy link
Member

I'll take it @eltonmesquita

@warengonzaga
Copy link
Member

PRed @eltonmesquita, thank you for the report @artisticLogicMK

artisticLogicMK added a commit to artisticLogicMK/animate.css that referenced this issue Aug 1, 2022
Made a correction of the issue i submitted animate-css#1572
artisticLogicMK added a commit to artisticLogicMK/animate.css that referenced this issue Aug 1, 2022
Renamed the flippers to their correct axis identifiers as given in the issue i submitted: animate-css#1572
@warengonzaga
Copy link
Member

pushed a fix for v5 release #1583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants