Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make BlockQuote a SPAN instead of extending MarkdownText so that it can be a child of MarkdownText #39

Open
andycmaj opened this issue Jun 23, 2020 · 0 comments

Comments

@andycmaj
Copy link
Owner

andycmaj commented Jun 23, 2020

we currently have:

<SectionBlock>
        <MarkdownText>{triggeringActivity.data.comment}</MarkdownText>
</SectionBlock>

// OR


<SectionBlock>
        <BlockQuote>{commentBody}</BlockQuote>
</SectionBlock>

we should be able to put BlockQuotes INTO markdown blocks.

<SectionBlock>
        <MarkdownText>
			Here's a comment from Dave: 

			<BlockQuote>{commentBody}</BlockQuote>
		</MarkdownText>
</SectionBlock>

hmmm can a BlockQuote be a CHILD of MarkdownText? practically, i thikn you'd sometimes want to be able to have markdown sections that CONTAIN block quotes and other things as well...

Originally posted by @andycmaj in https://github.com/asynchronous-dev/botany/pull/973

@andycmaj andycmaj changed the title hmmm can a BlockQuote be a CHILD of MarkdownText? practically, i thikn you'd sometimes want to be able to have markdown sections that CONTAIN block quotes and other things as well... make BlockQuote a SPAN instead of extending MarkdownText so that it can be a child of MarkdownText Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant