Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust reason byte #2

Open
hammmmy opened this issue Apr 8, 2017 · 0 comments
Open

Adjust reason byte #2

hammmmy opened this issue Apr 8, 2017 · 0 comments

Comments

@hammmmy
Copy link

hammmmy commented Apr 8, 2017

In the code, Intent.ACTION_TIME_CHANGED results in TimeProfile.ADJUST_MANUAL (0x01) but for Intent.ACTION_TIMEZONE_CHANGED the adjust reason value is set as 0x04.
According to the current time specs (https://www.bluetooth.com/specifications/adopted-specifications), "If the time information on the server device was set / changed manually, the “Manual Time Update” bit shall be set.
Note: If the time zone or DST offset were changed manually, this bit shall also be set."

In the example scenario, the user is asked to changed the timezone. Shouldn't the ADJUST_TIMEZONE value be 0x05 instead of 0x04 (and shouldn't the same thing apply to DST)?

    // Adjustment Flags
    public static final byte ADJUST_NONE     = 0x0;
    public static final byte ADJUST_MANUAL   = 0x1;
    public static final byte ADJUST_EXTERNAL = 0x2;
    public static final byte ADJUST_TIMEZONE = 0x5;
    public static final byte ADJUST_DST      = 0x9;
@hammmmy hammmmy changed the title Manual update in Adjust_reason Adjust reason byte Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant