Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to KSP #930

Open
1 of 2 tasks
tunjid opened this issue Mar 25, 2023 · 5 comments
Open
1 of 2 tasks

Migrate to KSP #930

tunjid opened this issue Mar 25, 2023 · 5 comments
Assignees
@AnirudhPudari

Comments

@tunjid
Copy link
Contributor

tunjid commented Mar 25, 2023 •
edited

Replace usages of KAPT with KSP as appropriate:

  • Move Room to KSP
  • Move Hilt to KSP
@AnirudhPudari
Copy link

@tunjid Hey, I can take this issue, can you please assign it to me.

@tunjid tunjid assigned tunjid and AnirudhPudari and unassigned tunjid Apr 8, 2023
@tunjid
Copy link
Contributor Author

tunjid commented Apr 8, 2023

@AnirudhPudari all yours!

@AnirudhPudari AnirudhPudari mentioned this issue Apr 9, 2023
Merged
@AnirudhPudari
Copy link

@tunjid Hi, I have made the changes as required. Please review. I was only able to migrate room to KSP. Hilt still doesn't have the support yet as mentioned here in list of supported libraries docs https://kotlinlang.org/docs/ksp-overview.html#supported-libraries. The issue tracker has no ETA provided on Hilt support till now since 2021.

Currently with this change we still will have to keep KAPT to support hilt. would you suggest keeping both KAPT and KSP or should we wait till hilt gets the KSP support ?

@tunjid
Copy link
Contributor Author

tunjid commented Apr 11, 2023 •
edited

@AnirudhPudari I've merged your PR, thanks again. I've also updated the tasks to show one of the items has been completed.

@AnirudhPudari
Copy link

@tunjid Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnirudhPudari AnirudhPudari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tunjid @AnirudhPudari