Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull to refresh doesn't work when there are no tasks #916

Open
dturner opened this issue Mar 14, 2023 · 3 comments
Open

Pull to refresh doesn't work when there are no tasks #916

dturner opened this issue Mar 14, 2023 · 3 comments
Assignees

Comments

@dturner
Copy link
Collaborator

dturner commented Mar 14, 2023

Steps to repro:

  • Load app, delete any existing tasks so that "You have no tasks!" is displayed
  • swipe vertically downwards

Expected outcome

  • The loading spinner is displayed

Actual outcome

  • Nothing happens

Further details:

Pull to refresh is implemented in the LoadingContent composable. This either displays empty content or if it is non empty (specified by the logic tasks.isEmpty() && !loading) a container which supports pull to refresh.

So the problem is that the empty content should be displayed inside a container which supports pull to refresh.

Additionally the code is currently using SwipeRefresh from the accompanist library which is deprecated and needs migrating https://google.github.io/accompanist/swiperefresh/#migration

@AnirudhPudari
Copy link

AnirudhPudari commented Mar 27, 2023

@dturner Please review the issue as addressed here in this PR #934. Thank you

@AnirudhPudari
Copy link

AnirudhPudari commented Apr 8, 2023

@dturner @manuelvicnt @tunjid Please take a look and review this PR #934. Thank you

@dturner
Copy link
Collaborator Author

dturner commented Jun 5, 2023

Sorry for the delay. Please fix the spotless formatting on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants