Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiccups with installation and coupon concern broken #158

Open
archonic opened this issue May 15, 2016 · 1 comment
Open

Hiccups with installation and coupon concern broken #158

archonic opened this issue May 15, 2016 · 1 comment

Comments

@archonic
Copy link

I've run into a few hiccups trying to install this. Coupon can't be blank for subscription, but session[:koudoku_coupon_code] isn't populated or mentioned as a part of setup. I'm under the impression that subscriptions should be allowed without coupons, but there should at least be read me instructions on populating the session coupon code or otherwise assigning.

It would ease installation to mention putting Plan and Coupon creation into seeds.rb and running rake db:seed.

From there, there's reference to nil methods on coupon here:
https://github.com/andrewculver/koudoku/blob/master/app/concerns/koudoku/subscription.rb#L78

I'm guessing there was an incomplete commit meant to build out coupons. When commenting out references to things that don't exist, the plan doesn't exist in Stripe. When are the plans meant to be created on the Stripe side? There's no instance of Stripe::Plan.create anywhere, and it's not mentioned in the readme.

@yas4891
Copy link
Collaborator

yas4891 commented May 16, 2016

session[:koudoku_coupon_code] is something I added in order to support koudoku_coupons.
Koudoku works without that extension.

As for the undefined method error, I am at a loss here right now. I think that belongs to the early implementation that someone else wrote. I found that implementation to be lacking and created koudoku_coupons as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants