Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag in the actual game cause the CV system to malfunction #39

Open
GoldExplosion opened this issue Sep 1, 2022 · 5 comments
Open

Lag in the actual game cause the CV system to malfunction #39

GoldExplosion opened this issue Sep 1, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@GoldExplosion
Copy link
Contributor

Whenever the game lags, the CV system doesn't realize this and detects the Shop Slots again causing a disruption between the actual game and the engine. Proper detection of lags needed.

@GoldExplosion
Copy link
Contributor Author

I would like to work on this. I also want to add proper error handling and other possible improvement to CV System. Can I take this issue?

@andreped
Copy link
Owner

andreped commented Sep 1, 2022

Yeah, thats true. Right now we have a lot of hard coded solutions. It is nice for developing and stuff, but likely will lead to issues for other people. Great if this could be done in a better way.

Sure! Just go ahead :)

@andreped andreped added the bug Something isn't working label Sep 1, 2022
@andreped
Copy link
Owner

andreped commented Apr 1, 2023

@GoldExplosion I was thinking of doing some improvements the framework. Actually trying to make a chrome extension such that people could try it with the web app in a more seemless manner. Mostly just to learn how to make web extensions.

Sadly, as the game has progressed quite a bit since last time I worked on this project, and both the sapai and sapai-gym projects not either been updated, the AI will likely not do well anymore, as the simulated and real environments have diverged.

@GoldExplosion
Copy link
Contributor Author

That sounds interesting. I want to apologise for not closing this issue ( became busy with irl stuff).

I want to contribute to this web extension if possible.

@andreped
Copy link
Owner

andreped commented Apr 3, 2023

That sounds interesting. I want to apologise for not closing this issue ( became busy with irl stuff).

No worries! I have been awfully busy myself. Just now that I had some time off to do other things.

I want to contribute to this web extension if possible.

I just made an Issue about it: #46. We could take the discussion there or in the Discussions tab.

Another key feature I want to add is to be able to run unit tests for deployment (see issue #49). I was hoping of boosting the code coverage from 21% closer to 100%. You could contribute there as well if you'd like. Up to you :]

@GoldExplosion GoldExplosion removed their assignment Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants