Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 8 #42

Open
stevenlauwers22 opened this issue Jun 21, 2019 · 7 comments
Open

Support for Angular 8 #42

stevenlauwers22 opened this issue Jun 21, 2019 · 7 comments

Comments

@stevenlauwers22
Copy link

stevenlauwers22 commented Jun 21, 2019

I've upgraded my application to Angular 8 and I'm getting some warnings on this package.
Could you update your package.json file to also allow angular 8, so I can get rid of these warnings.

warning " > [email protected]" has incorrect peer dependency "@angular/common@^6.0.0-rc.0 || ^6.0.0 || 7.0.0-rc.0 || ^7.0.0".
warning " > [email protected]" has incorrect peer dependency "@angular/core@^6.0.0-rc.0 || ^6.0.0 || 7.0.0-rc.0 || ^7.0.0".
@evolkmann
Copy link

Hi @stevenlauwers22, since this lib seems to be discontinued unfortunately, I took the time to rewrite this library to angular 9. I also removed much of the opinionated behaviour.

Maybe this is interesting for your: https://github.com/exportarts/ngx-cookie-banner

@stevenlauwers22
Copy link
Author

Hi @evolkmann, thanks for pointing out!

@HelainSchoonjans
Copy link

Ngx-cookie-banner unfortunately does not support Angular 8... Won't anyone fork and upgrade angular2-cookie-law?

@evolkmann
Copy link

@HelainSchoonjans You are right, it says so in the peer dependencies. I will change that in a moment and go back to v8. I did expect v9 to arrive earlier, and I am using the prerelease CLI on my machine already. Nevertheless, the software is still working with angular 8 I am pretty sure.

@evolkmann
Copy link

@HelainSchoonjans I did not fork it, because I wanted to get rid of the opinionated styling. It was easier to take only the useful parts of the logic and refactor them in the process.

@evolkmann
Copy link

@HelainSchoonjans You are right, it says so in the peer dependencies. I will change that in a moment and go back to v8. I did expect v9 to arrive earlier, and I am using the prerelease CLI on my machine already. Nevertheless, the software is still working with angular 8 I am pretty sure.

v0.0.3 has now been released: https://www.npmjs.com/package/ngx-cookie-banner

@andreasonny83
Copy link
Owner

I'm sorry but I'm not actively maintaining the package any more.
I will be happy to accept a PR to add compatibility from major Angular versions if you can help.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants