feat: pass SRI hashes for Git sources #87
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we avoid using `fetchGit` unlocked and we get better properties on caching, etc. Signed-off-by: Raito Bezarius <[email protected]>
RaitoBezarius
force-pushed
the
narhash-for-git
branch
from
ee043ab to
864a972
Compare
andir
reviewed
Jun 19, 2024
| @@ -6,6 +6,25 @@ pub struct PrefetchInfo { | |||
| hash: String, | |||
| } | |||
|
|
|||
| pub async fn hash_to_sri(hash_type: &str, hash: String) -> Result<String> { | |||
| let output = tokio::process::Command::new("nix") | |||
There was a problem hiding this comment.
Will this require a specific minimum nix version? e.g. 2.4 and newer?
There was a problem hiding this comment.
Only if we shell out, if we use Tvix, not really.
There was a problem hiding this comment.
If tvix manages to publish these operations in some useable format. I've some random bits and pieces from other nix-related projects that do this. Since I also want to remove reliance on nix-prefetch-url entirely and add that to npins.
|
(This is missing handling |
|
I would love to see this be merged. What's left to be done here? |
From what I can see:
other then that it's probably good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening this to leave it as an example (and because I need it), I may not have time to polish it for upstream inclusion, feel free to close it if you are not interested.
Could fix #71.