Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add example of using a resolver for metatags for markdown component #1014

Closed
2 tasks
brandonroberts opened this issue Apr 7, 2024 · 1 comment · Fixed by #1082
Closed
2 tasks

Docs: add example of using a resolver for metatags for markdown component #1014

brandonroberts opened this issue Apr 7, 2024 · 1 comment · Fixed by #1082

Comments

@brandonroberts
Copy link
Member

Which scope/s are relevant/related to the feature request?

Docs

Information

We have an example resolver for getting metatags for the route when using the custom markdown component.

https://github.com/analogjs/analog/blob/beta/apps%2Fblog-app%2Fsrc%2Fapp%2Fpages%2Fblog%2F%5Bslug%5D.page.ts#L16

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
AmGarera added a commit to AmGarera/analog that referenced this issue May 3, 2024
@AmGarera
docs: added example in docs of using a resolver for metatags for mark…
2d56281 
…down component (analogjs#1014)
@AmGarera AmGarera mentioned this issue May 3, 2024
Merged
22 tasks
@AmGarera
Copy link
Contributor

AmGarera commented May 3, 2024 •
edited

@brandonroberts I've submitted a PR for this issue. When you have the time let me know if anything needs to be tweaked/modified. Just glad I can give back in any way to the analog project and angular community as a whole!

AmGarera added a commit to AmGarera/analog that referenced this issue May 20, 2024
@AmGarera
docs: fixed outstanding comments for (analogjs#1014)
9b9572c
brandonroberts pushed a commit that referenced this issue May 21, 2024
@AmGarera
docs: added example in docs of using a resolver for metatags for mark…
40af6e1 
…down component (#1014) (#1082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brandonroberts @AmGarera