Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global suspended players report missing real names #236

Open
Glenalth opened this issue Sep 23, 2019 · 6 comments
Open

Global suspended players report missing real names #236

Glenalth opened this issue Sep 23, 2019 · 6 comments
Assignees
Labels

Comments

@Glenalth
Copy link
Collaborator

https://ork.amtgard.com/orkui/index.php?Route=Reports/suspended

The report here is missing mundane name information when being viewed by logged in officers and admins. Kingdom level reports seem to be functioning properly by blanking the field normally, but filling it in for officers.

@Glenalth Glenalth added the bug label Sep 23, 2019
@jrtaylor-com
Copy link
Collaborator

@Glenalth can you confirm this view needs names? I want to be sure they weren't removed per the COM request in 2019 for legal issues.

@Glenalth
Copy link
Collaborator Author

Mundane names should be visible for officers or else it is a useless report. I don't know what the COM request was and am not included on such things.

@jrtaylor-com
Copy link
Collaborator

@Glenalth right now the report will show names for people that have EDIT privileges for the Park/Kingdom the report is being run against. There isn't a check in place to determine if a logged in user is a kingdom officer or admin to determine if the fields should be shown.

I'll reach out to my KD rep to hit the COM up with the question of allowing persons from another org(kingdom) see the mundane names of persons not in their org (kingdom).

if (strlen($request['Token']) > 0 && ($mundane_id = Ork3::$Lib->authorization->IsAuthorized($request['Token'])) > 0 && Ork3::$Lib->authorization->HasAuthority($mundane_id, $request['Type'], $request['Id'], AUTH_EDIT)) { $restricted_access = true; } else { $restricted_access = false; }

	`								'GivenName' => $restricted_access&&$r->restricted==0?$r->given_name:"",
							'Surname' => $restricted_access&&$r->restricted==0?$r->surname:"",
							'OtherName' => $restricted_access&&$r->restricted==0?$r->other_name:"",`

@jrtaylor-com
Copy link
Collaborator

AIBOD will be discussing this in their upcoming meeting. I will post feedback once I receive their direction.

@jrtaylor-com jrtaylor-com self-assigned this Apr 22, 2021
@jrtaylor-com
Copy link
Collaborator

Agenda item was pushed to this Friday (tomorrow). Still waiting for AIBOD response to move forward.

@jrtaylor-com
Copy link
Collaborator

Sent a followup email to AIBOD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants