Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optimizer smoke test to Site Health integration #4869

Open
schlessera opened this issue Jun 16, 2020 · 0 comments
Open

Add Optimizer smoke test to Site Health integration #4869

schlessera opened this issue Jun 16, 2020 · 0 comments
Labels
Integration: WP Core Optimizer P2 Low priority WS:Perf Work stream for Metrics, Performance and Optimizer

Comments

@schlessera
Copy link
Collaborator

schlessera commented Jun 16, 2020

Feature description

If the Optimizer throws a fatal error, it will not take the server down, but rather fail silently and leave the unoptimized output to be sent to the browser.

This means you can have an inactive Optimizer (that just takes up server resources without producing a result) without knowing it.

The Site Health integration should be extended to add a smoke test that tries to optimize a basic page. This way, we can show a warning/error if the Optimizer is fataling. This might for example happen if you have misconfigured it via the configuration filters.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Site Health checks include a basic test of the Optimizer to make sure it does not fatal.

Implementation brief

  • Listen to an URL argument amp_site_health_test_optimizer=1
  • When the URL argument is present, ensure 'amp_enable_optimizer' is true
  • Use hardcoded content to send through the sanitization/validation/optimization pipeline
  • Catch exceptions/fatal errors that are happening
  • Ensure the end result is optimized AMP
  • If not, list the detected errors

QA testing instructions

Demo

Changelog entry

@kmyram kmyram added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 5, 2020
@westonruter westonruter added the P2 Low priority label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration: WP Core Optimizer P2 Low priority WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
Archived in project
Development

No branches or pull requests

3 participants