-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-iframe, amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags #4450
Comments
jerclarke
changed the title
amp-instagram and amp-youtube wrapped in unnecessary p tag
amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags
Mar 26, 2020
23 tasks
2 tasks
Just here to say, would still be great to get this consistent! Also noticed that this also applies to |
jerclarke
changed the title
amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags
amp-iframe, amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags
Feb 2, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
This is a continuation of #4358 where the same problem applied to
amp-facebook
and was fixed.The premise is that these
amp-*
objects should be in the root of the document, and not be wrapped in<p>
tags. Twitter already worked this way, and in #4358amp-facebook
was fixed to match.I've now noticed that
amp-iframe
,amp-instagram
,amp-youtube
,amp-soundcloud
face the same problem:As with the previous ticket, it's important to me because I need to style something that immediately follows the object (
amp-instagram+.translation
), but also generally it just seems like good practice all around.Instagram embed code:
YouTube embed code
Soundcloud embed code
Mostly likely this applies to other embeds as well. A general review would be greatly appreciated.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: