Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need this spinner support Angular 7 #51

Open
wd4444 opened this issue Nov 30, 2018 · 4 comments
Open

Need this spinner support Angular 7 #51

wd4444 opened this issue Nov 30, 2018 · 4 comments

Comments

@wd4444
Copy link

wd4444 commented Nov 30, 2018

Please help this library support Angular up to date

@Muhanady
Copy link

Actually it does support Angular 7, am using it with 7

@wd4444
Copy link
Author

wd4444 commented Nov 30, 2018

How does it work with Angular 7? I am using Angular ver. 7.1.1. It shows error when run npm install:
"npm WARN [email protected] requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself."

@MrNuTruT
Copy link

this is not a problem ! this is work on angular 7.X

@twindual
Copy link

twindual commented Mar 8, 2019

Had the same problem with installing the peer dependencies.
Here is one wasy to solve it:

-Open the "node_modules/ng4-loading-spinner/package.json" file
-Update the following section in the "peerDependencies": { ... } section
-Change:
-FROM: "@angular/core": "^6.0.0",
-TO: "@angular/core": "^6.0.0 || ^7.0.0",
-Save the file

This will let it work with Angular 7 libraries in your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants