Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching the official stdc++ version on Ubuntu? #185

Closed
aminya opened this issue Jul 24, 2023 · 5 comments · Fixed by #277
Closed

Matching the official stdc++ version on Ubuntu? #185

aminya opened this issue Jul 24, 2023 · 5 comments · Fixed by #277
Labels
question Further information is requested
Milestone

Comments

@aminya
Copy link
Owner

aminya commented Jul 24, 2023

setup-cpp has been using the latest version of stdc++ on Ubuntu. However, this implies that the compiled binary will ship/compile the required stdc++ or it is provided by the system. Otherwise, the user will get errors like GLIBXX ... was not found or other similar errors.

Should we match the latest stdc++ version that is available in the Ubuntu repositories, or should we continue to use the ppas?

Upvote & Fund

  • I am using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.

  • Thank you in advance for helping prioritize & fund our backlog.

Fund with Polar
@aminya aminya added the question Further information is requested label Jul 24, 2023
@aminya aminya pinned this issue Aug 29, 2023
@aminya
Copy link
Owner Author

aminya commented Sep 1, 2023

Since stdc++ might add a runtime dependency that is not bundled by default on Ubuntu, I think we should move forward with this decision.

@makslevental
Copy link

I think sticking to defaults is a very good idea. Was this change implemented?

@aminya
Copy link
Owner Author

aminya commented Dec 15, 2023

@makslevental Not implemented yet, and pull requests are welcome! This should mostly be pinning stdlib++ so that once a newer version of g++ is installed from the test-toolchain ppa, the stdlibc++ remains old. Or alternatively, we can avoid installing newer g++ on Ubuntu if not bundled in the default repositories.

@makslevental
Copy link

Sorry actually, after running around this morning trying to figure out a stdlibc++ issue, I realize what you're saying here is that the default gcc (with a version number) will install gcc-11 and the corresponding stdlibc++ wherever. I think that's perfectly fine right? If I use your action and instead of picking the version less gcc, I pick gcc-9 then I will get the "default" stdlibc++ and that's good. I think having the option is what's important (rather than necessarily the defaults). Certainly it might be surprising from some people that don't realize that gcc-11 ships with a newer stdlibc++ than the default (like I was earlier this morning) but it makes perfect sense after a bit of consideration.

So in summary: I retract my Yay and vote nay. Or at least I vote please don't remove the ability to install newer versions of gcc on ubuntu-20.04 :)

@aminya
Copy link
Owner Author

aminya commented Dec 17, 2023

@makslevental Yes, setup-cpp will still allow installing the latest GCC if you pass the version, but I was talking about the default. Instead of installing from the test toolchain, we can instead use the latest available in the repos when the user just passes true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
2 participants