Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider inlcuding the entity generation in ComponentEvent #720

Open
Imberflur opened this issue Jan 3, 2021 · 1 comment
Open

Consider inlcuding the entity generation in ComponentEvent #720

Imberflur opened this issue Jan 3, 2021 · 1 comment

Comments

@Imberflur
Copy link
Contributor

Description

Including the entity generation instead of just the index within the component event used by FlaggedStorage.

Motivation

When an entity is deleted removal events are generated for its components in FlaggedStorages. If another entity is created at the same index there is no way to tell if the removed components are from the old entity or the new one. When using this for network syncing the means we end up sending useless component removed events (since we can't be sure they don't apply to the new entity).

Drawbacks

This would be a breaking change and would increase the size of ComponentEvent

Unresolved questions


I would be happy to implement this if approved.

@Dollab
Copy link

Dollab commented Jan 15, 2021

This would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants