Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs refer to non-existent derive(Saveload) instead of derive(ConvertSaveload) #661

Open
Kawzeg opened this issue Dec 12, 2019 · 0 comments
Labels

Comments

@Kawzeg
Copy link

Kawzeg commented Dec 12, 2019

Description

The ConvertSaveload doc references #[derive(Saveload)], which should be #[derive(ConvertSaveload)] (see https://github.com/amethyst/specs/pull/460/files#diff-822e080d915774f7d11cc2c5bd503bffR84)

Meta

Rust version: cargo 1.39.0 (1c6ec66d5 2019-09-30)
Specs version / commit: 0.15.1 / master commit c182a28
Operating system: linux

Reproduction

Steps to reproduce the behavior:

  1. Go to the specs project root directory
  2. Run grep -rnw . -e 'derive(Saveload)'
  3. See places using the wrong name

Expected behavior

The documentation should show derive(ConvertSaveload) instead.

@Kawzeg Kawzeg added the bug label Dec 12, 2019
@Kawzeg Kawzeg changed the title Docs refer to non-existant derive(Saveload) instead of derive(ConvertSaveload) Docs refer to non-existent derive(Saveload) instead of derive(ConvertSaveload) Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant