Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failureThresholdType=percent is confusing #323

Open
noomorph opened this issue Jan 18, 2023 · 1 comment
Open

failureThresholdType=percent is confusing #323

noomorph opened this issue Jan 18, 2023 · 1 comment

Comments

@noomorph
Copy link
Contributor

According to the code, when you define failureThreshold: 0.01, failureThresholdType: 'percent', that means 1% in fact.

I think this is misleading because percent is 1/100 (per+cent), and it is not a fraction (0..1).

Could you please rename it to fraction and add the real percent unit, i.e. 0.01 percent → 0.0001 and 1 percent → 0.01 accordingly?

Thanks in advance.

@joriswitteman
Copy link

Second this. I've lost quite some time misunderstanding what to fill here. Like OP says, failureThresholdType percent is entirely misleading if 0.1 in fact means 10%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants