Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why so many silent/altered errors? #17

Open
nopeless opened this issue Mar 14, 2023 · 2 comments
Open

Why so many silent/altered errors? #17

nopeless opened this issue Mar 14, 2023 · 2 comments
Labels
bug Something isn't working question Further information is requested

Comments

@nopeless
Copy link

Saw the post on reddit. Why does the library suppress many errors and even alter some errors from the code? What is the justification behind this?

@nicobarray nicobarray added the question Further information is requested label Mar 14, 2023
@Dam-Buty
Copy link
Collaborator

Hi @nopeless and thank you for that question ! (kind of)

You are right that v2 currently suppresses errors. It was kind of a rush job on my end when i refactored the flow control logic. I opted to go with a throw ... catch logic because it makes for simpler code inside the library but totally forgot the note i had made to handle errors throwing inside the callbacks.

This threw me into a loop of factoring and future-proofing some of the internal code, which isn't done yet but v2.1 is coming along soon-ish.

@Dam-Buty Dam-Buty added the bug Something isn't working label Apr 23, 2023
@nopeless
Copy link
Author

Thanks for looking into my comment

glad you accept what was wrong. Let me know when you fix it, as I get notifs from this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants