[BUG] parse_expr macro fails if one of the parsings have failed

[b1ek]

Describe the bug
see #504

To Reproduce
it is an internal compiler bug, which doesn't happen in normal amber use case.

let me explain:

there are multiple ExprType, and it parses the Expr with the parse_expr macro:

amber/src/modules/expression/expr.rs

Lines 135 to 160 in cd0338a

	fn parse(&mut self, meta: &mut ParserMetadata) -> SyntaxResult {
	let result = parse_expr!(meta, [
	ternary @ TernOp => [ Ternary ],
	range @ BinOp => [ Range ],
	or @ BinOp => [ Or ],
	and @ BinOp => [ And ],
	equality @ BinOp => [ Eq, Neq ],
	relation @ BinOp => [ Gt, Ge, Lt, Le ],
	addition @ BinOp => [ Add, Sub ],
	multiplication @ BinOp => [ Mul, Div, Modulo ],
	types @ TypeOp => [ Is, Cast ],
	unops @ UnOp => [ Neg, Not ],
	literals @ Literal => [
	// Literals
	Parentheses, Bool, Number, Text,
	Array, Null, Nameof, Status,
	// Function invocation
	FunctionInvocation, Command,
	// Variable access
	VariableGet
	]
	]);
	*self = result;
	Ok(())
	}
	}

and the parse_expr fails if one of the parsings have failed, as an example what happened in #504 - the VariableGet parsing failed, and it didn't get to try to parse Len.

Expected behavior
for it to parse all of them until at least one Ok

Additional context
its a rather sneaky issue because its hard to undestand what is the problem here. maybe i don't understand how it works, since i didnt even look at the macro source code - it looks like machine code to me.

i think @Ph0enixKM is literally the only person who actually understands how macros work, so please do comment

[b1ek]

if i move it down it will fail

big image

but if i make it as it is in the PR it will work as expected

big image