[BUG] Incorrect Boolean Casting

[andre0xFF]

Describe the bug
When casting a string value "true" to a boolean, the resulting boolean value matches the incorrect if condition. This issue occurs both when executing the script directly and when compiling it to bash. Amber version: amber 0.3.4-alpha

To Reproduce
Script:

main(args) {
    let foo = "true" as Bool

    echo "Foo is {foo}"

    if foo == true {
        echo "it's true"
    }

    if foo == false {
        echo "it's false"
    }
}

Execution:

❯ amber test.ab
Foo is true
it's false

Compiled to bash:

❯ amber test.ab test.sh
❯ ./test.sh
Foo is true
it's false

Expected behavior
The output should be:

Foo is true
it's true

Additional context
The issue seems to be related to the incorrect casting of string values to boolean. The string "true" is casted to a boolean but matches the false condition.

[andre0xFF]

Possible workaround by running the condition in a bash command like let service_url = $if [ \"\$IS_LOCAL\" = \"false\" ]; then echo \"foo.bar:8000\"; else echo \"localhost:8000\"; fi$?

[Mte90]

Probably we need a better conversion for this type internally.

PS: Amber when execute the code compiles it and run a bash process so it is the same.

[Ph0enixKM]

Is it a valid cast though? The cast from Text to Number is marked as "absurd". The same should apply to Text->Bool.

• A warning should be appeared that this is an "absurd cast" just like when casting Text to Num
• The normal behaviour should check if the text == "1" and be a bash representation of "1" for true and "0" for false. This should be for casting anything to Bool

[KrosFire]

Is it a valid cast though? The cast from Text to Number is marked as "absurd". The same should apply to Text->Bool.

• A warning should be appeared that this is an "absurd cast" just like when casting Text to Num
• The normal behaviour should check if the text == "1" and be a bash representation of "1" for true and "0" for false. This should be for casting anything to Bool

I agree that "true" as Bool shouldn't convert a value to boolean true. If you want a Boolean from text, you should just compare texts