Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cant inject FullpageDirective #66

Open
vinverdy opened this issue May 8, 2020 · 4 comments
Open

cant inject FullpageDirective #66

vinverdy opened this issue May 8, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@vinverdy
Copy link

vinverdy commented May 8, 2020

Please include FullpageDirective in publish_api, therefore i could inject it to component, and access fullpage api from the directive, instead of using output ref. Kudos
@alvarotrigo
Copy link
Owner

Can you explain it a bit more?
Or perhaps provide a pull request? Thanks! 👍

@alvarotrigo alvarotrigo added the enhancement New feature or request label May 8, 2020
@vinverdy
Copy link
Author

vinverdy commented May 8, 2020

#67

its my first pr, sorry if its aint right. take a look. thanks

@alvarotrigo
Copy link
Owner

@alidihaw do you think this makes any sense now?

@alidihaw
Copy link
Contributor

Basicly its different way to call directly directive, the new version its already export for directive
so only need add example to demo @alvarotrigo
Here the pr: #126

Thanks to @vinverdy 👍

@alvarotrigo alvarotrigo mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alvarotrigo @vinverdy @alidihaw