Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a saved collection does not indicate that the view is not saved/modified #2425

Open
stdedos opened this issue Jan 30, 2024 · 4 comments

Comments

@stdedos
Copy link

stdedos commented Jan 30, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Create a query, save it as collection
  2. Edit it

Expected behavior

Save button changes color

Actual behavior

Save button stays black/gray

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Platform: [e.g. Chrome extension, mozilla addon, desktop app, npm package, snap]
  • Version [e.g. 22]

Additional context

More and more nowadays we are accustomed to this "auto-save behavior".

However, for the collections, it would feel weird to me that a saved query (i.e., a blueprint) was "randomly replaced" by a temporary "playground" modification

@imolorhe
Copy link
Collaborator

Sorry I'm not sure I properly understand the issue. If you have screenshots, those would help too.

@stdedos
Copy link
Author

stdedos commented Feb 9, 2024

Sorry I'm not sure I properly understand the issue

Editing a saved query is not treated as "unsaved".
There's no indication (a) that it's modified, (b) it's unsaved.

If you have screenshots, those would help too.

That is ... sort of my point. There's no visual indication. I'm not sure how screenshots would help in this case.

@WaseemMansour
Copy link

@imolorhe Mainly what he's saying is that Once you save a collection, the Save button should be disabled. and enabled again if you change the request/query - that's to say check if it's changed and the user may want to save this change.
Example from Postman
image
When I change the request
image

I'm checking the possible first contribution to an open-source project.
And this might be a good start, I will check the repo locally and see If I can do that till I get your good-to-go confirmation. and any hints that might help me achieve that.

@imolorhe
Copy link
Collaborator

That makes sense. @WaseemMansour sure feel free to pick this up! Let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants