Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update follow value on empty response #88

Open
Dantese opened this issue Mar 8, 2022 · 0 comments
Open

Update follow value on empty response #88

Dantese opened this issue Mar 8, 2022 · 0 comments

Comments

@Dantese
Copy link
Contributor

Dantese commented Mar 8, 2022

When the API returns no alerts then the returned follow value is ignored. In some scenarios, the follow value might be upgraded without returning any data so we should always check if the follow value has changed and save it. Currently, we stop processing the API response too early:

nfr/alerts/poller.go

Lines 85 to 87 in 86bbd14

if len(alerts.Alerts) == 0 {
continue
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant