Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

[New Rule] GitHub Action with no default timeout #12

Open
idanshahar opened this issue Aug 28, 2022 · 1 comment
Open

[New Rule] GitHub Action with no default timeout #12

idanshahar opened this issue Aug 28, 2022 · 1 comment
Labels
good first issue Good for newcomers rule requests Requests for new rule up for grabs Waiting for someone to take it

Comments

@idanshahar
Copy link
Contributor

Add a policy to enforce GitHub actions workflows with no default timeout definition.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes
@idanshahar idanshahar added enhancement New feature or request good first issue Good for newcomers up for grabs Waiting for someone to take it labels Aug 28, 2022
@idanshahar idanshahar changed the title GitHub Action with no timeout policy [New Policy] GitHub Action with no default timeout Aug 28, 2022
@idanshahar idanshahar changed the title [New Policy] GitHub Action with no default timeout [New Rule] GitHub Action with no default timeout Aug 30, 2022
@idanshahar idanshahar added rule requests Requests for new rule and removed enhancement New feature or request labels Aug 30, 2022
@dimabru
Copy link
Contributor

dimabru commented Sep 1, 2022 •
edited
Loading

@idanshahar
Github already has a default timeout of 360 minutes (6 hours) for each job. Are we sure we want to add a rule that forces users to add timeouts even though one already exists?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers rule requests Requests for new rule up for grabs Waiting for someone to take it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idanshahar @dimabru