Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use all-contributors in react jsx #786

Open
tomsun28 opened this issue Apr 21, 2024 · 2 comments
Open

use all-contributors in react jsx #786

tomsun28 opened this issue Apr 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@tomsun28
Copy link

Is your feature request related to a problem? Please describe.

hi community, thanks for the great project.

We want to add all-contributors in react jsx file, however, because all-contributors uses the HTML <!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section --> to mark the beginning, <!-- is considered invalid in JSX.
Is there any other good solution?

@tomsun28 tomsun28 added the enhancement New feature or request label Apr 21, 2024
@fabianoaljava
Copy link

One solution is to use a JavaScript comment instead of an HTML comment. You could use something like:
{/* ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section */}

This way, JSX won't throw any errors, and you can still mark the beginning of your all-contributors section. Give it a try and see if it works for you! If you have any more questions, feel free to ask.

@tomsun28
Copy link
Author

tomsun28 commented May 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants