Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enhance CommonTestUtils#retry log for easier troubleshooting #253

Open
2 tasks done
liyubin117 opened this issue Dec 23, 2024 · 0 comments · May be fixed by #254
Open
2 tasks done

[Feature] Enhance CommonTestUtils#retry log for easier troubleshooting #253

liyubin117 opened this issue Dec 23, 2024 · 0 comments · May be fixed by #254
Labels
feature New feature or request

Comments

@liyubin117
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

There are many issues caused by as follows:

Error:  com.alibaba.fluss.server.replica.fetcher.ReplicaFetcherITCase  Time elapsed: 616.934 s  <<< FAILURE!
java.lang.AssertionError: Attempt failed.
	at com.alibaba.fluss.testutils.common.CommonTestUtils.retry(CommonTestUtils.java:156)
	at com.alibaba.fluss.server.testutils.FlussClusterExtension.waitUtilAllGatewayHasSameMetadata(FlussClusterExtension.java:361)
	at com.alibaba.fluss.server.testutils.FlussClusterExtension.start(FlussClusterExtension.java:177)
	at com.alibaba.fluss.server.testutils.FlussClusterExtension.beforeAll(FlussClusterExtension.java:123)

the log hides many valuable messages of each test execution, and we can expose them for easier troubleshooting

Solution

we can expose them for easier troubleshooting

Anything else?

No response

Willingness to contribute

  • I'm willing to submit a PR!
@liyubin117 liyubin117 added the feature New feature or request label Dec 23, 2024
@liyubin117 liyubin117 changed the title [Feature] enhance CommonTestUtils#retry log for easier troubleshooting [Feature] Enhance CommonTestUtils#retry log for easier troubleshooting Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant