-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding static analysis #709
Comments
Hello, thanks for the report. Code is there: https://github.com/algolia/algoliasearch-client-php/tree/next |
Hey, thats great to see! But even in a new major static analysis would still be beneficial to the overall quality of the project. Especially since this is a new major, and adding/changing types could be a BC break, this seems like the perfect time to add those. |
Description
Consider using a static analysis tool (like PHPStan or Pslam), in order to catch basic errors, like the class not found issue introduced recently.
Currently there is no way to verify that code that is not covered by tests isn't broken. With static analysis all code would be automatically type checked, which should make it (nearly) impossible for these kind of errors to happen.
It shouldn't be too much work to set it up with real low strictness, which should catch any basic errors. At a later point it could be configured to be more strict, catching more specific errors.
If you need any help with setting this up, i'd be more than happy to help.
The text was updated successfully, but these errors were encountered: