Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventSubtype to insights client #749

Closed
raed667 opened this issue Jan 24, 2024 · 1 comment · Fixed by #763
Closed

Add eventSubtype to insights client #749

raed667 opened this issue Jan 24, 2024 · 1 comment · Fixed by #763
Assignees

Comments

@raed667
Copy link
Contributor

raed667 commented Jan 24, 2024

  • Algolia Client Version: 3.31.0
  • Language Version: 1.21.5

Description

According to this documentation the insights API accepts an eventSubtype that seems to be missing from the package's type:

type Event struct {
	EventType string    `json:"eventType"`
	EventName string    `json:"eventName"`
	Index     string    `json:"index"`
	UserToken string    `json:"userToken"`
	Timestamp time.Time `json:"-"`
	ObjectIDs []string  `json:"objectIDs,omitempty"`
	Positions []int     `json:"positions,omitempty"`
	QueryID   string    `json:"queryID,omitempty"`
	Filters   []string  `json:"filters,omitempty"`
}

This would be a useful parameter to support.

@vredens
Copy link

vredens commented May 17, 2024

+1

@Fluf22 Fluf22 self-assigned this Jun 24, 2024
Fluf22 added a commit that referenced this issue Jun 25, 2024
| Q                 | A
| ----------------- | ----------
| Bug fix?          | no
| New feature?      | yes
| BC breaks?        | no
| Related Issue     | Fix #749 [CR-6348]
| Need Doc update   | no


## Describe your change

Add the optional subtype property to the Event struct for Insights

## What problem is this fixing?

Users couldn't send an event subtype


[CR-6348]:
https://algolia.atlassian.net/browse/CR-6348?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants