You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Setting language by the language GET parameter has several issues.
If the user has never set the language via the language drop down, setting the language GET parameter to a non existent or non supported language causes the Easy!Appointments to throw error.
No error should be thrown and the GET parameter should be ignored.
Setting the language via GET isn't persistent. The change should be stored in the session just like when you select the language via the drop down.
The language GET parameter should also accept the more widely use ISO 639-1 two letter language codes. For backwards compatibility the current use of the English names of languages should be maintained.
Other notes:
The order of precedence when setting the user language should be:
GET parameter
session
Browser preferred language
I'll do a PR regarding the above soon.
The text was updated successfully, but these errors were encountered:
alxlab-zone66x
pushed a commit
to alxlab-zone66x/easyappointments
that referenced
this issue
Nov 8, 2024
Setting language by the
language
GET parameter has several issues.language
GET parameter to a non existent or non supported language causes the Easy!Appointments to throw error.No error should be thrown and the GET parameter should be ignored.
Setting the language via GET isn't persistent. The change should be stored in the session just like when you select the language via the drop down.
The
language
GET parameter should also accept the more widely use ISO 639-1 two letter language codes. For backwards compatibility the current use of the English names of languages should be maintained.Other notes:
The order of precedence when setting the user language should be:
I'll do a PR regarding the above soon.
The text was updated successfully, but these errors were encountered: