Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setting language by GET parameter #1620

Open
alxlab-zone66x opened this issue Nov 8, 2024 · 1 comment
Open

Improve setting language by GET parameter #1620

alxlab-zone66x opened this issue Nov 8, 2024 · 1 comment

Comments

@alxlab-zone66x
Copy link

Setting language by the language GET parameter has several issues.

  1. If the user has never set the language via the language drop down, setting the language GET parameter to a non existent or non supported language causes the Easy!Appointments to throw error.

image

No error should be thrown and the GET parameter should be ignored.

  1. Setting the language via GET isn't persistent. The change should be stored in the session just like when you select the language via the drop down.

  2. The language GET parameter should also accept the more widely use ISO 639-1 two letter language codes. For backwards compatibility the current use of the English names of languages should be maintained.

Other notes:

The order of precedence when setting the user language should be:

  1. GET parameter
  2. session
  3. Browser preferred language

I'll do a PR regarding the above soon.

@alextselegidis
Copy link
Owner

Hello!

Thanks, let me check this and write back

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants