Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Shell Integration For Nushell #181

Open
Ktoks opened this issue Dec 30, 2024 · 5 comments
Open

Support Shell Integration For Nushell #181

Ktoks opened this issue Dec 30, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ktoks
Copy link

Ktoks commented Dec 30, 2024

Problem
I would like to propose Nushell shell integration be supported.

Feature
Ctrl-r, Ctrl-t, etc. . . features be supported - similarly to fzf.

Examples
Ctrl-r - allows the user to search past command uses in $HOME/.config/nushell
Ctrl-t - allows the user to search for files in the current directory

Additional context
I don't know that there is additional context needed.

@Ktoks Ktoks added the enhancement New feature or request label Dec 30, 2024
@alexpasmantier alexpasmantier added the good first issue Good for newcomers label Jan 7, 2025
@Ktoks
Copy link
Author

Ktoks commented Jan 8, 2025

After using this for a while with Bash and ZSH - I have noticed behavior that leads me to believe that when CTRL-R is pressed - it's just running TV directly on a channel - instead of implementing CTRL-R's behavior - similar to the way FZF or Bash/ZSH/Nushell's default CTRL-R works.

I think this functionality could be more broadly used if it were set up in a way where the user can begin typing a command, hit CTRL-R - an immediately look at the user's current shell history.

As TV stands now - if the user types a partial command and hits CTRL-R - TV fails when you don't have a channel set up for the partial command in the terminal. To get the CTRL-R functionality, the prompt must be empty - or the user has to set up every possible configuration to get the same functionality FZF provides.

Do you want me to put in a separate issue for this?

@alexpasmantier
Copy link
Owner

The behaviour you're describing is I believe the one bound to C-t, but C-r should behave as a regular shell history command. If that's not the case, it's not intended and I'd need to investigate why that happens.

@alexpasmantier
Copy link
Owner

(sorry for the terrible gif image quality)

cmd_history-ezgif com-optimize

@alexpasmantier alexpasmantier self-assigned this Jan 9, 2025
@Ktoks
Copy link
Author

Ktoks commented Jan 9, 2025

You're right - it's when I use C-t without having a channel for the partial command.
My mistake. I am unsure how I got confused yesterday morning.

@alexpasmantier
Copy link
Owner

No problem, I feel relieved 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants