Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use config.base also in production #467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use config.base also in production #467

wants to merge 2 commits into from

Conversation

FynniX
Copy link

@FynniX FynniX commented Apr 3, 2024 •
edited

Description

Instead of forcing a base of './' in production it now allows the user to decide via config.
Fixes #466

Additional context

This is needed for example for prerendering in preact where each route has its own html file

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

@alex8088
Copy link
Owner

alex8088 commented Apr 4, 2024

base option should not be set in production. More details: https://vitejs.dev/config/shared-options.html#base. In production, we use file protocol to load page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base variable gets ignored
2 participants
@FynniX @alex8088