Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using bindTo gives findDOMNode error #91

Open
huwshimi opened this issue Jun 25, 2024 · 0 comments · May be fixed by #92
Open

using bindTo gives findDOMNode error #91

huwshimi opened this issue Jun 25, 2024 · 0 comments · May be fixed by #92
Assignees
@alex-cory

Comments

@huwshimi
Copy link
Contributor

Describe the bug
usePortal with bindTo produces the following errors in React 18:

Warning: findDOMNode is deprecated and will be removed in the next major release. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

⚠️ Make a Codesandbox ⚠️
Sandbox.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this sandbox.
  2. Open your browser console.
  3. Click on the button to open the portal
  4. See the findDOMNode error in the console.

Expected behavior
There shouldn't be an error when using bindTo.
@huwshimi huwshimi linked a pull request Nov 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-cory alex-cory

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove deprecated findDOMNode huwshimi/react-useportal
2 participants
@huwshimi @alex-cory