-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: This library has no tests at all? #444
Comments
That's a valid observation. In that case maybe you could contribute some tests? I'd be more than happy to review them. On a side note - CalendarController is removed in v3.0.0, which is right around the corner. See the changelog for more details. |
@aleksanderwozniak I saw that the CalendarController is removed, what is the alternative for it? |
@swissonid |
@aleksanderwozniak if you are interested then I can contribute some tests for |
@burhanrashid52 |
A test suite has now been added - closing. |
After reporting a bug I was attempting to fix the issue myself but I don't really feel confident in contribute to it since there are no tests. Keeping in mind that we really do appreciate the work done here, since we are using this from more than a year in production. I'm not attempting in any way to undermine the quality or the effort taken in making this library, but at this stage is really not easy to be to contribute it.
How other people feeling about this? There is any plan to add some tests, at least in a basic unitary level, for the core functionalities such as the ones in
calendar_controller
code?The text was updated successfully, but these errors were encountered: