Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: This library has no tests at all? #444

Closed
nerder opened this issue Mar 21, 2021 · 6 comments
Closed

Discussion: This library has no tests at all? #444

nerder opened this issue Mar 21, 2021 · 6 comments

Comments

@nerder
Copy link
Contributor

nerder commented Mar 21, 2021

After reporting a bug I was attempting to fix the issue myself but I don't really feel confident in contribute to it since there are no tests. Keeping in mind that we really do appreciate the work done here, since we are using this from more than a year in production. I'm not attempting in any way to undermine the quality or the effort taken in making this library, but at this stage is really not easy to be to contribute it.

How other people feeling about this? There is any plan to add some tests, at least in a basic unitary level, for the core functionalities such as the ones in calendar_controller code?

@aleksanderwozniak
Copy link
Owner

That's a valid observation. In that case maybe you could contribute some tests? I'd be more than happy to review them.

On a side note - CalendarController is removed in v3.0.0, which is right around the corner. See the changelog for more details.

@swissonid
Copy link

@aleksanderwozniak I saw that the CalendarController is removed, what is the alternative for it?

@aleksanderwozniak
Copy link
Owner

@swissonid
Rebuilding the widget with updated values - check this readme and #434

@burhanrashid52
Copy link

@aleksanderwozniak if you are interested then I can contribute some tests for CellContnent or 1-2 end-to-end integration tests.

@aleksanderwozniak
Copy link
Owner

@burhanrashid52
Thanks. I'm already working on a test suite myself, but if I end up needing some extra help, I'll reach out to you.

@aleksanderwozniak
Copy link
Owner

A test suite has now been added - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants