-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alda REPL: "Play right away" offset calculation doesn't work with voices #415
Comments
My hunch is that this has something to do with the way Part instances are cloned in the voices implementation. On this line could maybe try using (In the "sync offsets" we are passing into the transmitter, I see that we are using part.origin already, which I think is correct.) |
馃悶 Bug report 馃悶
Description
In the Alda REPL use case, the user is appending additional events to the score, and as they're doing that, we want to play the new notes immediately, not wait until they would come up in the score. There shouldn't be any delay between entering a line of code in the REPL and hearing it.
To support this use case, we play some tricks in the note scheduling code, where the caller can pass in a map of "sync offsets" for each part, and we will subtract the offset for each part from all of its notes. As a result, we end up with notes that would be played right away, not however far into the score they would be if this were an Alda score file and not a REPL session.
This has been working great, but I just noticed that for some reason, it doesn't seem to work if you use voices.
Steps to Reproduce
alda repl
)piano: V1: o4 c d e V2: o5 c d e
and press Enter.Expected Behavior
Every time you enter this line of code in the REPL, you hear the result immediately.
Actual Behavior
The first time, you hear the result immediately.
The second time, the result is delayed by 3 beats.
The third time, the result is delayed by 6 beats, etc.
Environment
Operating system and version: Ubuntu 20.04
Alda version:
Health check:
Logs: not relevant here
The text was updated successfully, but these errors were encountered: