-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up the read/preprocess in ABFE workflow #359
Comments
Perhaps a good starting point for discussion is to see how much speed-up it can bring and if it's something people will likely always want to use. Do you have some benchmark comparisons for typical data sets and how it scales? |
It is quite a big speed up. Assume that we have 64 lambda windows where each one has 6251 time points. The preprocess goes from |
Apparently |
Just make it explicit anyway. |
In the current ABFE workflow set up, the file read and preprocess are running on a single thread, which is kind of waste of time when reading a lot of files.
In the ABFE workflow, I think we could speed things up by wrap the read and preprocess in a multiprocess thread.
I'm thinking of adding a new dependency
joblib
for that. I wonder if I could get some advice if the community are happy with that.The text was updated successfully, but these errors were encountered: