Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faild to restore FastResume (v3.0.0-beta-0106) #587

Open
Passerby774 opened this issue Dec 29, 2022 · 0 comments
Open

Faild to restore FastResume (v3.0.0-beta-0106) #587

Passerby774 opened this issue Dec 29, 2022 · 0 comments

Comments

@Passerby774
Copy link

If InfoHashes have V1 and V2,
code "InfoHashes == fastResume.InfoHashes" (TorrentManager.cs: line 1,105) is always failed.
Because "InfoHashes" contains V1 and V2, but "fastResume.InfoHashes" contains only V1 (or V2).

Here is the Encode method of FastResume. (FastResume.cs: line 115)
{ InfoHashKey, new BEncodedString(InfoHashes.V1OrV2.Span.ToArray ()) },

Improvement plan
Plan A: Encode(Load) V1 and V2 hashes in FastResume.
Plan B: Compare V1OrV2 hashes. (ex. "InfoHashes.V1OrV2 == fastResume.InfoHashes.V1OrV2")

Thx for reading my childish English and developing a wonderful library! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant