Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many deprecation warnings triggered #144

Open
johnthagen opened this issue Jul 3, 2019 · 1 comment
Open

Many deprecation warnings triggered #144

johnthagen opened this issue Jul 3, 2019 · 1 comment

Comments

@johnthagen
Copy link
Contributor

The following warnings will break compatibility with future Python versions (3.8) or DRF (3.10, 3.11).

See: https://travis-ci.org/alanjds/drf-nested-routers/jobs/553444409

home/travis/build/alanjds/drf-nested-routers/.tox/py37-django2.0-drf3.7/lib/python3.7/site-packages/django/db/models/fields/__init__.py:442: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  if name == "choices" and isinstance(value, collections.Iterable):
/home/travis/build/alanjds/drf-nested-routers/tests/test_dynamic_routers.py:72: DeprecationWarning: Please use assertEqual instead.
  get_regex_pattern(urls['basicmodel-list']), u'^detail/$'

... (many similar warnings)
/home/travis/build/alanjds/drf-nested-routers/tests/test_dynamic_routers.py:40: PendingDeprecationWarning: `detail_route` is pending deprecation and will be removed in 3.10 in favor of `action`, which accepts a `detail` bool. Use `@action(detail=True)` instead.
  @detail_route(methods=["post"])
/home/travis/build/alanjds/drf-nested-routers/tests/test_dynamic_routers.py:48: PendingDeprecationWarning: `list_route` is pending deprecation and will be removed in 3.10 in favor of `action`, which accepts a `detail` bool. Use `@action(detail=False)` instead.
  @list_route()
/home/travis/build/alanjds/drf-nested-routers/tests/test_viewsets.py:62: RemovedInDRF311Warning: The `base_name` argument is pending deprecation in favor of `basename`.
  router.register('root', RootViewSet, base_name='root')
/home/travis/build/alanjds/drf-nested-routers/tests/test_viewsets.py:64: RemovedInDRF311Warning: The `base_name` argument is pending deprecation in favor of `basename`.
  root_router.register(r'child', ChildViewSet, base_name='child')
/home/travis/build/alanjds/drf-nested-routers/tests/test_viewsets.py:65: RemovedInDRF311Warning: The `base_name` argument is pending deprecation in favor of `basename`.
  root_router.register(r'child-with-nested-mixin', ChildWithNestedMixinViewSet, base_name='child-with-nested-mixin')
@alanjds
Copy link
Owner

alanjds commented Jul 3, 2019

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants