Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription argument to SRE config #1904

Closed
5 tasks done
jemrobinson opened this issue May 17, 2024 · 0 comments · Fixed by #1943
Closed
5 tasks done

Add subscription argument to SRE config #1904

jemrobinson opened this issue May 17, 2024 · 0 comments · Fixed by #1943
Labels
bug Problem when deploying a Data Safe Haven.

Comments

@jemrobinson
Copy link
Member

jemrobinson commented May 17, 2024

✅ Checklist

  • I have searched open and closed issues for duplicates.
  • This is a request for a new feature in the Data Safe Haven or an upgrade to an existing feature.
  • The feature is still missing in the latest version.
  • I have read through the documentation.
  • This isn't an open-ended question (open a discussion if it is).

🍓 Suggested change

Currently SREs don't have their own subscription argument and will be deployed into the same subscription as the SHM and Context. We should make this user-configurable.

See also #1633.

🚂 How could this be done?

Add a subscription name/ID option to the SRE config and ensure this is enforced at deployment time.

@jemrobinson jemrobinson added this to the Release 5.0.0rc2 milestone May 17, 2024
@jemrobinson jemrobinson added the bug Problem when deploying a Data Safe Haven. label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem when deploying a Data Safe Haven.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant