Skip to content

Commit

Permalink
fix for xzkostyan#286
Browse files Browse the repository at this point in the history
  • Loading branch information
akurdyukov committed Jan 22, 2024
1 parent c34be61 commit b8b0619
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion clickhouse_sqlalchemy/drivers/native/connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _prepare(self, context=None):
if self._stream_results and execute_iter:
execute = execute_iter
settings = settings or {}
settings['max_block_size'] = execution_options['max_row_buffer']
settings['max_block_size'] = execution_options.get('max_row_buffer', 1000)

execute_kwargs = {
'settings': settings,
Expand Down
11 changes: 11 additions & 0 deletions tests/drivers/native/test_cursor.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,14 @@ def test_check_iter_cursor(self):
text('SELECT number FROM system.numbers LIMIT 5')
)
self.assertListEqual(list(rv), [(x,) for x in range(5)])

def test_execute_with_stream(self):
rv = self.session.execute(text("SELECT * FROM system.numbers LIMIT 1")).yield_per(10)

self.assertEqual(len(rv.fetchall()), 1)

def test_with_stream_results(self):
rv = self.session.execute(text("SELECT * FROM system.numbers LIMIT 1"),
execution_options={"stream_results": True})

self.assertEqual(len(rv.fetchall()), 1)

0 comments on commit b8b0619

Please sign in to comment.