Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate disposal #30

Open
akolman opened this issue Jan 4, 2024 · 0 comments
Open

Validate disposal #30

akolman opened this issue Jan 4, 2024 · 0 comments
Labels
Code check
Milestone
v0.1.0

Comments

@akolman
Copy link
Owner

akolman commented Jan 4, 2024

For split archives, validate that:

  1. Unneeded streams passed from callback are immediately disposed.
  2. Used streams are properly disposed once EggArchive is disposed
@akolman akolman added this to the v0.1.0 milestone Jan 15, 2024
akolman added a commit that referenced this issue Apr 18, 2024
@akolman
Updated RELEASES. Closes #30.
4263a8d
@akolman akolman mentioned this issue Apr 18, 2024
Merged
akolman added a commit that referenced this issue Apr 18, 2024
@akolman
30 validate disposal (#38)
036fec1 
* Updated EggArchive to throw ObjectDisposedException when attempting to access after Disposal.

Also added test cases to confirm that underlying streams are disposed when they should be.

* Updated RELEASES.  Closes #30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code check
Projects
None yet
Milestone
v0.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

30-validate-disposal akolman/EggDotNet
1 participant
@akolman