Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TestKit] SupervisorStrategy for TestActor is unused #7062

Open
roee88 opened this issue Jan 14, 2024 · 1 comment · May be fixed by #7221
Open

[TestKit] SupervisorStrategy for TestActor is unused #7062

roee88 opened this issue Jan 14, 2024 · 1 comment · May be fixed by #7221
Labels
akka-testkit Akka.NET Testkit issues potential bug
Milestone
1.5.32

Comments

@roee88
Copy link

roee88 commented Jan 14, 2024

Version Information

v1.5

Describe the bug

#4148 added public IActorRef ChildActorOf(Props props, string name, SupervisorStrategy supervisorStrategy) and similar methods to TestKitBase. However, the supervisorStrategy does not take effect.

It looks like InternalTestActor doesn't override SupervisorStrategy() to actually use its private _supervisorStrategy. See

akka.net/src/core/Akka.TestKit/Internal/InternalTestActor.cs

Line 24 in 0782c7d

private DelegatingSupervisorStrategy _supervisorStrategy = new();

@Aaronontheweb Aaronontheweb added this to the 1.5.16 milestone Jan 16, 2024
@Aaronontheweb
Copy link
Member

Thanks, we'll look into this

@Aaronontheweb Aaronontheweb modified the milestones: 1.5.16, 1.5.17 Jan 31, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.17, 1.5.18 Mar 5, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.18, 1.5.19 Mar 12, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.19, 1.5.20 Apr 15, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.20, 1.5.21 Apr 29, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.21, 1.5.22 May 28, 2024
@yanpitangui yanpitangui linked a pull request Jun 2, 2024 that will close this issue
Draft
2 tasks
@Aaronontheweb Aaronontheweb added the akka-testkit Akka.NET Testkit issues label Jun 2, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.22, 1.5.23, 1.5.24, 1.5.25 Jun 3, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.25, 1.5.26 Jun 14, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.26, 1.5.27 Jun 27, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.27, 1.5.28 Jul 25, 2024
@Aaronontheweb Aaronontheweb removed this from the 1.5.28 milestone Sep 4, 2024
@Aaronontheweb Aaronontheweb added this to the 1.5.29 milestone Sep 4, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.29, 1.5.30, 1.5.31 Oct 1, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.31, 1.5.32 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
akka-testkit Akka.NET Testkit issues potential bug
Projects
None yet
Milestone
1.5.32
Development

Successfully merging a pull request may close this issue.

Make InternalTestActor override its SupervisionStrategy yanpitangui/akka.net
2 participants
@roee88 @Aaronontheweb