Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @InternalApi where applicable #472

Open
octonato opened this issue Dec 17, 2020 · 1 comment
Open

Add @InternalApi where applicable #472

octonato opened this issue Dec 17, 2020 · 1 comment

Comments

@octonato
Copy link
Member

We should be more clear what it internal API and what not. I will say that for a plugin, most APIs are internal.

The DAOs and eventually some utility classes can be public.

I suggest that we schedule this to be done before 5.0.0.

@patriknw
Copy link
Member

I don't think we should spend time on trying to make current shape of the plugin binary compatible with a well defined public api. The heavy usage of traits and no thought of that from the beginning makes it impossible. We will eventually rewrite it and then we should take this into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants