Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Handling for NoElytra/NoEnter flags when flying around the world #85

Closed
ElementAnimationCouncil opened this issue Oct 24, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@ElementAnimationCouncil

Is your feature request related to a problem? Please describe.
Hello, a lot of my players are getting frustrated when exploring our world by flying with an elytra. If they happen to fly into a claim with NoFly on and are high off the ground, they stop flying and fall to their death; often resulting in the loss of items and they are unsure where they died. When the NoEnter flag is set on a claim they fly into, it will keep them stuck in fly mode in midair with no way of getting out except to teleport.

Describe the solution you'd like
I would like to see a feature for each of these flags to better handle these situations. Perhaps when they fly into a claim with NoEnter on, it will just teleport them back to the ground, or to the other side of the claim, etc. Maybe the same thing for the NoElytra flag, or it could give them slow falling and they glide to the ground. I am curious what you think would be possible.

Describe alternatives you've considered
I've looked around the config to see if there is a setting that would mitigate this, but there is not. I can't think of anything that I could do with other plugins, since this is an issue that is directly tied to how this plugin handles these two flags.

Additional context
Nothing additional to note. Please let me know if there is anything you need from me or if you have any additional questions. Thank you!

@ElementAnimationCouncil ElementAnimationCouncil added the enhancement New feature or request label Oct 24, 2024
@akdukaan
Copy link
Owner

Are you using an old version of GPF? In the current version 5.13.6, neither of these should be an issue.

@ElementAnimationCouncil
Copy link
Author

Yes, that is the version we are using and players are still reporting this issue. Is there a config setting that I am missing that would perhaps mitigate the issue? Or something else with the implementation?
image

We are also using the most up-to-date version of GriefPrevention, if that is helpful in any way.
image

@akdukaan
Copy link
Owner

Looks like NoFlight has the code to prevent fall damage after a player's flight is disabled from the flag, but NoElytra doesn't. As for getting stuck in midair, I thought I'd fixed that earlier, but I was able to get my server to also have the same issue. Not sure if I broke it or if my fix just didn't work. Will work on both of these soon.

@akdukaan akdukaan added bug Something isn't working and removed enhancement New feature or request labels Nov 12, 2024
@akdukaan
Copy link
Owner

Issue with NoElytra fixed in 5.13.6.121 which you can download at https://jenkins.luminescent.dev/job/GPFlags/

Other issue I might need some more time to look into. Not sure why it's doing that.

@ElementAnimationCouncil
Copy link
Author

Thank you so much! I'll drop this in and report back if I notice any bugs or regressions with this fix. I appreciate the quick responses. :)

@ArduFish
Copy link

@akdukaan what is the difference between NoElytra and NoFlight?

@ElementAnimationCouncil
Copy link
Author

@akdukaan Just confirmed with some of our users that fall damage is indeed being negated. Thank you for your help, let me know when you find a solution for the NoEnter flag!

@akdukaan
Copy link
Owner

akdukaan commented Dec 29, 2024

@akdukaan what is the difference between NoElytra and NoFlight?

NoElytra is for gliding with elytras and NoFlight is for flying like in creative mode or with /fly

@akdukaan Just confirmed with some of our users that fall damage is indeed being negated. Thank you for your help, let me know when you find a solution for the NoEnter flag!

Fixed in b126 https://jenkins.luminescent.dev/job/GPFlags/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants