Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add flag to disable McMMO passive skills #19

Open
KayaEdwin opened this issue May 31, 2022 · 2 comments
Open

[Feature Request] Add flag to disable McMMO passive skills #19

KayaEdwin opened this issue May 31, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@KayaEdwin
Copy link

Is your feature request related to a problem? Please describe.
Players are attempting to create PvP arenas/events where their McMMO skills don't impact the fights. The flag currently available - ''NoMcMMOSkills'' doesn't impact impactful passive skills included in McMMO (Axe Mastery, info: https://mcmmo.fandom.com/wiki/Axes_(Combat)#Axe_Mastery) meaning that fights are still majorly decided by a players' McMMO skills,

Describe the solution you'd like
I'd like an extra flag to be added to GriefPreventionFlags that includes all McMMO benefits, including these passive skills.

Describe alternatives you've considered
Using the McMMO-included WorldGuard flags to disable McMMO, though this would be too much work to maintain properly.

Additional context
None

@KayaEdwin KayaEdwin added the enhancement New feature or request label May 31, 2022
@akdukaan
Copy link
Owner

akdukaan commented Aug 2, 2022

I wasn't able to find an API to do this. If one exists and I just couldn't find it, or if McMMO adds one in the future, I can make a flag for it then.

@MaksyKun
Copy link

MaksyKun commented Sep 22, 2024

You'll probably need to check for all the events mcmmo provides seperated to block passive actions. Know passives can be extracted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants