Add ability to pass in css class to spinner and bar #178
Conversation
|
I realized that the background was overwriting some styles in my css class, namely background-color. I'm guessing that most people are wanting to style it based on a class, so the loader probably shouldn't set background in that case. Also, my [ngClass] code was old and wrong, updated to work. |
|
could you please update readme https://github.com/aitboudad/ngx-loading-bar#customize-ngx-loading-bar |
| @@ -6,12 +6,18 @@ import { LoadingBarService } from './loading-bar.service'; | |||
| template: ` | |||
| <ng-container *ngIf="value != null ? value : (value$ | async) as progress"> | |||
| <div *ngIf="includeSpinner" class="ngx-spinner"> | |||
There was a problem hiding this comment.
spinnerClass should be set here
|
I'm not sure if we do really need such inputs 🤔, to use |
|
@aitboudad Thx for the hint. Styling the loading bar with works great and I can use Angular Material Theming that way. It did not work without the |
|
I have to revoke my previous comment. With proper Angluar 12 theming it does not work. This PR would be really great. |
Closes #141
Not sure what you'd like to call the inputs, feel free to change them.